fix(windows): add PowerShell compatibility fallbacks for ls, wc, proxy, discover, session#2728
Open
jlaportebot wants to merge 4 commits into
Open
Conversation
- Update has_limit_flag to detect -nN form (e.g., -n20) - Update parse_user_limit to parse -nN form - Add tests for -nN form (single and multi-digit) - All existing tests pass Fixes: rtk-ai#2665
…y, discover, session Addresses issue rtk-ai#1248: RTK Windows PowerShell Compatibility Gaps Changes: - ls.rs: On Windows, detect when 'ls' is not a real executable (PowerShell alias) and suggest 'rtk tree .' as native alternative - wc_cmd.rs: On Windows, detect when 'wc' is not available and provide PowerShell/Git Bash/WSL alternatives - main.rs (proxy): On Windows, warn about PowerShell aliases (ls, dir, echo, pwd, cp, mv, rm, cat, man, which) and built-ins (cd, set, exit, cls, history, alias, function) that aren't real executables - discover/mod.rs: On Windows, when no Claude sessions found, provide helpful info about session storage location (%USERPROFILE%\.claude\projects\) - analytics/session_cmd.rs: Same as above for session command All changes are conditional compilation (cfg(target_os = "windows")) so they only affect Windows users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1248
Changes
All changes are conditional compilation (cfg(target_os = "windows")) so they only affect Windows users.
Testing
AI Disclosure
This PR was developed with AI assistance.